Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 12: Code-Review+1 (7 comments) overall looks good, just a few nits and one question on verifying the type of the auto-incrementing column on the server side. http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9910 PS12, Line 9910: rows.size(), kNumRows nit: the expected values comes first, otherwise it's much harder to comprehend the message if this assertion ever triggers http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9921 PS12, Line 9921: the blow column specs the column specs below http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9928 PS12, Line 9928: ASSERT_TRUE(s.IsInvalidArgument()); nit for here and below: in case if this assert ever triggers, for easier troubleshooting its better to have this as ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9930 PS12, Line 9930: } Do we have a check on this on the server side as well? There might be another client that doesn't verify the schema before sending request to the server side. http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc@487 PS12, Line 487: set_incorrectly naming nit: maybe name this 'err_field_incorrectly_set'? http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc@497 PS12, Line 497: max_value naming nit: maybe name this 'err_max_value'? http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/tablet/tablet_auto_incrementing-test.cc File src/kudu/tablet/tablet_auto_incrementing-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/tablet/tablet_auto_incrementing-test.cc@91 PS12, Line 91: ASSERT_TRUE(s.IsInvalidArgument()) nit for here and elsewhere: it's easier to debug if this ever fails if this written as ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 21 Dec 2022 22:52:33 +0000 Gerrit-HasComments: Yes
