Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/19281/8/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/19281/8/src/kudu/tablet/compaction.cc@748 PS8, Line 748: // Since 'max_memory_usage_' isn't protected against concurrent access, : // this method should be invoked from the same thread that performs merge : // compaction. Can we make use of compact_flush_lock here? http://gerrit.cloudera.org:8080/#/c/19281/7/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/19281/7/src/kudu/tablet/compaction_policy.cc@174 PS7, Line 174: nit: implemented in such http://gerrit.cloudera.org:8080/#/c/19281/8/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/19281/8/src/kudu/tablet/compaction_policy.cc@77 PS8, Line 77: postone nit:postpone http://gerrit.cloudera.org:8080/#/c/19281/8/src/kudu/tablet/compaction_policy.cc@112 PS8, Line 112: false Just an observation: With rowset compaction memory estimate enabled, during server start, this would be false and little to none stats would be available to make a decision on the memory factor. In such a case, old logic would apply and that should be fine as long as we have flags that can enable/disable the whole thing. -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:38:43 +0000 Gerrit-HasComments: Yes
