Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19281/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19281/7//COMMIT_MSG@13 PS7, Line 13: nit: Extra Space Same in lines 17 and 19 http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc@170 PS6, Line 170: actor = (h->TotalCount() > 0 && h->MeanValu > Yes, we do. That's because just after restarting a tablet server there isn Right, I guess the question even if we have the metrics available is there a possible scenario where we might need to enforce the usage of the flag forcefully? -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 21:13:51 +0000 Gerrit-HasComments: Yes
