Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc@170 PS6, Line 170: FLAGS_rowset_compaction_delta_memory_factor Just a thought: Do we ever want to enforce the usage of this flag even if we have the the needed tablet metrics? http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/rowset_info.h@84 PS6, Line 84: avalable nit: available http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/rowset_info.cc@298 PS6, Line 298: //if Do we need this line? -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 17 Dec 2022 01:42:26 +0000 Gerrit-HasComments: Yes
