Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 )
Change subject: [KUDU-3430] Implement getting flags filter logic in tool side ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19393/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19393/1//COMMIT_MSG@9 PS1, Line 9: (version: 1.14.2) There is no such a version in official community. http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@451 PS1, Line 451: flags_to_get and flags_tags nit: --flags_to_get and --flags_tags http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@454 PS1, Line 454: Kudu server. nit: could you limit the comments to the same width, regularly 100 chars. http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@461 PS1, Line 461: unordered_set<string> contained_tags; : for (const auto& tag : flag.tags()) { : contained_tags.insert(tag); : } nit: can be simplified by this? unordered_set<string> contained_tags(flag.tags().begin(), flag.tags().end()); http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@473 PS1, Line 473: } How about add a test to disable server side filter and check the filter on CLI tool side works? -- To view, visit http://gerrit.cloudera.org:8080/19393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858 Gerrit-Change-Number: 19393 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 29 Dec 2022 16:11:38 +0000 Gerrit-HasComments: Yes
