Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 )
Change subject: [KUDU-3430] Implement getting flags filter logic in tool side ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@473 PS1, Line 473: > There has already existed a unit test to check getting flags, see: kudu-too Maybe you can add a new flag on server to disable filter for testing purpose. http://gerrit.cloudera.org:8080/#/c/19393/2/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19393/2/src/kudu/tools/tool_action_common.cc@452 PS2, Line 452: ,but nit: ", but" -- To view, visit http://gerrit.cloudera.org:8080/19393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858 Gerrit-Change-Number: 19393 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 30 Dec 2022 05:55:40 +0000 Gerrit-HasComments: Yes
