Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 )
Change subject: [KUDU-3430] Implement getting flags filter logic in tool side ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@451 PS1, Line 451: -flags_to_get and -flags_ta > nit: --flags_to_get and --flags_tags Done http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@454 PS1, Line 454: ment filter > nit: could you limit the comments to the same width, regularly 100 chars. Done http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@461 PS1, Line 461: unordered_set<string> contained_tags(flag.tags().begin(), flag.tags().end()); : for (const auto& tag : filter_tags) { : if (ContainsKey(contained_tags, tag)) { : > nit: can be simplified by this? Done http://gerrit.cloudera.org:8080/#/c/19393/1/src/kudu/tools/tool_action_common.cc@473 PS1, Line 473: > How about add a test to disable server side filter and check the filter on There has already existed a unit test to check getting flags, see: kudu-tool-test.cc#TestGetFlags, which both server side and tool side have filter logic. I found no method to only disable sever side filter logic. -- To view, visit http://gerrit.cloudera.org:8080/19393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858 Gerrit-Change-Number: 19393 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 30 Dec 2022 02:16:28 +0000 Gerrit-HasComments: Yes
