Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 13: (7 comments) http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9910 PS12, Line 9910: kNumRows, rows.size() > nit: the expected values comes first, otherwise it's much harder to compreh Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9921 PS12, Line 9921: the column specs belo > the column specs below Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/client-test.cc@9928 PS12, Line 9928: ASSERT_TRUE(s.IsInvalidArgument()) > nit for here and below: in case if this assert ever triggers, for easier tr Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/client/schema.cc@486 PS12, Line 486: } > Should we check immutable here? Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc@487 PS12, Line 487: err_field_incor > naming nit: maybe name this 'err_field_incorrectly_set'? Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/common/row_operations.cc@497 PS12, Line 497: err_max_v > naming nit: maybe name this 'err_max_value'? Done http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/tablet/tablet_auto_incrementing-test.cc File src/kudu/tablet/tablet_auto_incrementing-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/12/src/kudu/tablet/tablet_auto_incrementing-test.cc@91 PS12, Line 91: ASSERT_TRUE(s.IsInvalidArgument()) > nit for here and elsewhere: it's easier to debug if this ever fails if this Done -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 13 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Jan 2023 22:54:30 +0000 Gerrit-HasComments: Yes
