Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19398/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19398/1/src/kudu/util/maintenance_manager.cc@312 PS1, Line 312: KLOG_EVERY_N(INFO, 1200) << "Maintenance manager is disabled."; It would be nice if you give advice how to enable it, like how we do in https://github.com/apache/kudu/blob/master/src/kudu/tablet/tablet_replica_mm_ops.cc#L164 -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 1 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 04 Jan 2023 15:38:18 +0000 Gerrit-HasComments: Yes
