Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 2: (2 comments) Good advices. Thank you. http://gerrit.cloudera.org:8080/#/c/19398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19398/1//COMMIT_MSG@10 PS1, Line 10: But : restart tserver sometimes very slow. > Is this slowness because of maintenance ops? The problem 'tserver bootstrap slowly' does not matter with maintenance ops. This is another problem, its main reason: replaying LMB' metadata/data and replaying wals. I mean the problem may cause some other maintenance cost. eg, the patch: https://gerrit.cloudera.org/c/18569/, it's purpuse is that speed tserver's bootstrap http://gerrit.cloudera.org:8080/#/c/19398/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19398/1/src/kudu/util/maintenance_manager.cc@312 PS1, Line 312: if (shutdown_) { > It would be nice if you give advice how to enable it, like how we do in htt Done -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 2 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 13 Jan 2023 10:49:26 +0000 Gerrit-HasComments: Yes
