Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19398/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19398/2/src/kudu/util/maintenance_manager.cc@312 PS2, Line 312: if (shutdown_) { : return; : } nit: maybe move this out of the 'if (!FLAGS_enable_maintenance_manager)...' block? -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 2 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 08:02:07 +0000 Gerrit-HasComments: Yes
