Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] limit number of rows when dumping a rowset ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19369/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19369/3//COMMIT_MSG@9 PS3, Line 9: The --nrows flag for 'local_replica dump rowset' doesn't : work if --dump_all_columns is enabled. I am not able to understand from patch why dumping of rowset doesn't work with "dump_all_columns" flag. It would be great if you could capture that in here. http://gerrit.cloudera.org:8080/#/c/19369/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19369/3/src/kudu/tools/tool_action_local_replica.cc@a1090 PS3, Line 1090: Considering default values for rows_left as -1 and dump_all_columns set to true, what was stopping DebugDump above(at line no. 1053) from dumping all rows? -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 11 Jan 2023 18:30:13 +0000 Gerrit-HasComments: Yes
