Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] return immediately after the limit number of rows have been dumped ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19369/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19369/5//COMMIT_MSG@7 PS5, Line 7: return Use upper case? http://gerrit.cloudera.org:8080/#/c/19369/5/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/19369/5/src/kudu/tablet/memrowset.cc@151 PS5, Line 151: Status MemRowSet::DebugDump(int64_t* rows_left, vector<string> *lines) { How about defining 2 functions: DebugDumpImpl(int64_t* rows_left, vector<string> *lines) DebugDump(vector<string> *lines) DebugDump() will call DebugDumpImpl(nullptr, &lines) to implement the origin logic. And DebugDumpImpl() can be used by dumping rowset. The benefits is: DebugDump() no need to change the interface, functions using it no need to be modified. -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 13 Jan 2023 03:02:45 +0000 Gerrit-HasComments: Yes
