Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] return immediately after the limit number of rows have been dumped ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM. http://gerrit.cloudera.org:8080/#/c/19369/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19369/2//COMMIT_MSG@8 PS2, Line 8: : The --nrows flag for 'local_replica dump rowset' : just limits the last output row co > Thansk! Done http://gerrit.cloudera.org:8080/#/c/19369/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19369/2/src/kudu/tools/tool_action_local_replica.cc@a1048 PS2, Line 1048: > I meant it's able to early break instead of collect all rows and limit the Yes. The patch has the improvement benefit. If only fix the bug, what I said is enough. LGTM. -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 12 Jan 2023 12:32:18 +0000 Gerrit-HasComments: Yes
