Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 16: (6 comments) http://gerrit.cloudera.org:8080/#/c/18471/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18471/16//COMMIT_MSG@7 PS16, Line 7: plumb JWT authentication into clients Can you expand the commit message? Also, maybe add yourself as author and Andrew as co-author? http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: PS16: What are these changes for? Should they be in another patch? http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/rpc/client_negotiation.cc@200 PS16, Line 200: // When using SASL authentication, verifying the server's certificate is Please update this comment http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: PS16: Again, no need to reorder includes if the file is untouched otherwise. http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/security/tls_handshake.h File src/kudu/security/tls_handshake.h: PS16: Same as in negotiation.cc http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/16/src/kudu/server/server_base.cc@249 PS16, Line 249: "When true, read the JWT token out of the RPC and extract user " Maybe expand on this comment to indicate that this enables JWT authentication and what that means in practice. -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 16 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 18:38:48 +0000 Gerrit-HasComments: Yes
