Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 12: (2 comments) Overall looks good, just a few nits. Also, IWYU isn't yet happy: http://jenkins.kudu.apache.org/job/kudu-gerrit/26896/BUILD_TYPE=IWYU/console http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/client/client.cc@354 PS12, Line 354: const auto& jwt = pb.jwt(); : messenger->set_jwt(jwt); nit: could be shorten to messenger->set_jwt(pb.jwt()); ? http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/server/server_base.cc@262 PS12, Line 262: TAG_FLAG(enable_jwt_token_auth, experimental); : TAG_FLAG(jwt_validate_signature, experimental); : TAG_FLAG(jwt_validate_signature, unsafe); : TAG_FLAG(jwt_allow_without_tls, experimental); : TAG_FLAG(jwt_allow_without_tls, unsafe); : TAG_FLAG(jwks_file_path, experimental); : TAG_FLAG(jwks_url, experimental); nit: from the readability and maintenance perspectives, it would be a bit simpler if the definition and tag assignment are kepr together, something like for the majority of flags declared in this file (e.g. --rpc_default_keepalive_time_ms) -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 17 Dec 2022 01:08:06 +0000 Gerrit-HasComments: Yes
