Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18471 )
Change subject: plumb JWT authentication into clients ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/client/client.cc@354 PS12, Line 354: messenger->set_jwt(pb.jwt()); : } > nit: could be shorten to Done http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18471/12/src/kudu/server/server_base.cc@262 PS12, Line 262: TAG_FLAG(jwt_allow_without_tls, experimental); : TAG_FLAG(jwt_allow_without_tls, unsafe); : : DEFINE_string(jwks_file_path, "", : "File path of the pre-installed JSON Web Key Set (JWKS) for JWT verification."); : TAG_FLAG(jwks_file_path, experimental); : > nit: from the readability and maintenance perspectives, it would be a bit s Done -- To view, visit http://gerrit.cloudera.org:8080/18471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfc2640c047a2e3bb5ea03aea4439cea2532e23 Gerrit-Change-Number: 18471 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 15:39:29 +0000 Gerrit-HasComments: Yes
