Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 22: (3 comments) http://gerrit.cloudera.org:8080/#/c/19272/21/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/21/src/kudu/client/schema.cc@342 PS21, Line 342: KuduColumnSpec* KuduColumnSpec::NonUniquePrimaryKe > We may remove this API so that user is not allowed to add auto-incrementing Done http://gerrit.cloudera.org:8080/#/c/19272/20/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/20/src/kudu/client/session-internal.cc@376 PS20, Line 376: > As discussed in the meeting, server side will also disable upsert for table Yep, I'm convinced. I changed accordingly. http://gerrit.cloudera.org:8080/#/c/19272/21/src/kudu/client/table_alterer-internal.cc File src/kudu/client/table_alterer-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/21/src/kudu/client/table_alterer-internal.cc@116 PS21, Line 116: turn Status::AlreadyPresent("can't add reserved name", s.spec->data_->name); : } > Should we not allow user to add an auto-incrementing column in Alter Table This is a good catch! Yes we don't want this. Changed this, to only check the name. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 22 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 24 Jan 2023 11:50:40 +0000 Gerrit-HasComments: Yes
