Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 )
Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime ...................................................................... Patch Set 3: (1 comment) The test failure in TSAN mode seems related. http://gerrit.cloudera.org:8080/#/c/19398/3/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19398/3/src/kudu/util/maintenance_manager.cc@311 PS3, Line 311: if (shutdown_) { Seems we need to acquire the 'lock_' before using 'shutdown_' in this place. -- To view, visit http://gerrit.cloudera.org:8080/19398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7029b22a4c8ce58094501e71a6c22271d4f0b2 Gerrit-Change-Number: 19398 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 02 Feb 2023 14:37:37 +0000 Gerrit-HasComments: Yes
