Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19473 )
Change subject: [clock] add sanity check to detect wall clock jumps ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG@23 PS1, Line 23: condition nit: condition is http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG@40 PS1, Line 40: However, if a problem is observed at some inadequate VMs such : as ones in Azure Cloud, it's now possible to enable the guardrail : to detect such an issue. There are chances that this clock issue may go unnoticed unless there is a specific monitoring for such an error going on. If the clock error goes unnoticed (probably that's what happened in this case as well) and wrong clock timestamp persists and gets propagated to replicas, how would enabling the flag help after that? http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG@46 PS1, Line 46: opeations nit: operations http://gerrit.cloudera.org:8080/#/c/19473/1/src/kudu/clock/hybrid_clock.h File src/kudu/clock/hybrid_clock.h: http://gerrit.cloudera.org:8080/#/c/19473/1/src/kudu/clock/hybrid_clock.h@238 PS1, Line 238: captured nit: Did you mean "captured at" ? http://gerrit.cloudera.org:8080/#/c/19473/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/19473/1/src/kudu/clock/hybrid_clock.cc@165 PS1, Line 165: 15 * 60 Any specific reason to choose 15 minutes of max allowed divergence? -- To view, visit http://gerrit.cloudera.org:8080/19473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I630783653717d975a9b2ad668e8bd47b7796d275 Gerrit-Change-Number: 19473 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 06 Feb 2023 06:21:41 +0000 Gerrit-HasComments: Yes
