Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19473 )

Change subject: [clock] add sanity check to detect wall clock jumps
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19473/1//COMMIT_MSG@40
PS1, Line 40: However, if a problem is observed at some inadequate VMs such
            : as ones in Azure Cloud, it's now possible to enable the guardrail
            : to detect such an issue.
> The idea is to turn on this flag if it's found that the cluster is prone cl
Thank you for the response.
Just summarising yesterday's discussion here:
- It would make sense to enable this by default since it might be too late when 
we find out the issue and then enable this check since the wrong timestamp may 
have already been persisted on disk. As you mentioned, you have a WIP patch 
where you are enabling this check by default so that should take care of it.
- We are awaiting more data on this, if and when received might helps us 
augment this patch further. That may also make it more robust and target 
oriented in terms of fixing only part/case that is broken.


http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG@10
PS2, Line 10: the ntp_adjtime() call jumped 40+ years ahead when running 
kudu-tserver
> Good work., it's would be very useful. we have encountered several time thi
That is a valuable information, Yuqi.
Do you think this issue is reproducible? If yes, it would be great if you could 
capture the steps here.
Also, did you hit this issue on an Azure VM?



--
To view, visit http://gerrit.cloudera.org:8080/19473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I630783653717d975a9b2ad668e8bd47b7796d275
Gerrit-Change-Number: 19473
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Tue, 07 Feb 2023 10:01:21 +0000
Gerrit-HasComments: Yes

Reply via email to