Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19473 )
Change subject: [clock] add sanity check to detect wall clock jumps ...................................................................... Patch Set 2: (3 comments) A nice work. http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG@10 PS2, Line 10: the ntp_adjtime() call jumped 40+ years ahead when running kudu-tserver Good work., it's would be very useful. we have encountered several time this same problem. It's pending at my todo list more than 1 year, but I haven't study it now, of course I also don't know the reason. In a word, good work. http://gerrit.cloudera.org:8080/#/c/19473/2/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/19473/2/src/kudu/clock/hybrid_clock.cc@439 PS2, Line 439: if (is_wall_clock_jump_check_enabled_) { I am not sure If it is better that use 'FLAGS_enable_wall_clock_jump_check' and 'wall_clock_jump_threshold_s' / 'FLAGS_wall_clock_jump_threshold_us' directly and remove the two member variables. Using them directly, we can support turn on/off the gflags at runtime and avoid restarting kudu modules. http://gerrit.cloudera.org:8080/#/c/19473/2/src/kudu/clock/hybrid_clock.cc@448 PS2, Line 448: if (abs(wall_delta_usec - mono_delta_usec) > wall_clock_jump_threshold_usec_) what about PREDICT_FALSE -- To view, visit http://gerrit.cloudera.org:8080/19473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I630783653717d975a9b2ad668e8bd47b7796d275 Gerrit-Change-Number: 19473 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 09:42:15 +0000 Gerrit-HasComments: Yes
