Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control ...................................................................... Patch Set 2: (9 comments) Thank you for adding this. http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9 PS1, Line 9: lead full nit: lead to full http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9 PS1, Line 9: sans nit: scans http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10 PS1, Line 10: So I add nit: Add http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10 PS1, Line 10: perception not sure what you mean perception here? Do you want to say "without warning" ? http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11 PS1, Line 11: in nit: on http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11 PS1, Line 11: to nit: flag to http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429 PS1, Line 429: FLAGS_show_slow_scans = false; FLAGS_show_slow_scans seems to be already disabled when you come here. Either get rid of line 373 or remove this statement. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434 PS1, Line 434: // Create a slow scan scenarios. I guess you can also add one more test case where you can enable FLAGS_show_slow_scans and see if slow scan works fine. Just an idea- it might as well be an assertion with no NULL vector. Or if you find a better way to validate that slow scan ran and completed. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc@71 PS1, Line 71: perception I am not quite clear on usage of this word here. It would help if you could explain it in one line, for my understanding. -- To view, visit http://gerrit.cloudera.org:8080/19480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6 Gerrit-Change-Number: 19480 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Feb 2023 11:20:05 +0000 Gerrit-HasComments: Yes
