KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control ...................................................................... Patch Set 3: (9 comments) Thanks for your reviews and I've updated the patch. Please help to check it again. Thanks a lot. http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9 PS1, Line 9: scan > nit: scans Done http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@9 PS1, Line 9: lead to > nit: lead to full Done http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10 PS1, Line 10: Add --sh > nit: Add Done http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@10 PS1, Line 10: expectatio > not sure what you mean perception here? I mean without expectation. http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11 PS1, Line 11: on > nit: on Done http://gerrit.cloudera.org:8080/#/c/19480/1//COMMIT_MSG@11 PS1, Line 11: to > nit: flag to Done http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429 PS1, Line 429: FLAGS_show_slow_scans = false; > FLAGS_show_slow_scans seems to be already disabled when you come here. The default value is false and I check it in line 372. Then I set it to true to enable the slow scans show in line 373 so I can get the right value in line 411 and line 424. So in here before line 429 the value is true. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434 PS1, Line 434: // Create a slow scan scenarios. > I guess you can also add one more test case where you can enable FLAGS_show Yes, this case has done in line 424. Thanks for your advice. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/tserver/scanners.cc@71 PS1, Line 71: perception > I am not quite clear on usage of this word here. It would help if you could I mean expectation. And I will update the comments. -- To view, visit http://gerrit.cloudera.org:8080/19480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6 Gerrit-Change-Number: 19480 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Feb 2023 11:50:19 +0000 Gerrit-HasComments: Yes
