Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19480 )
Change subject: [www] add slow scans show control ...................................................................... Patch Set 4: (5 comments) Overall changes look good to me. Just some minor comments. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@429 PS1, Line 429: FLAGS_show_slow_scans = false; > The default value is false and I check it in line 372. Ah! My bad! For some reason I incorrectly though that flag is always set to false. Thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/19480/1/src/kudu/client/scan_token-test.cc@434 PS1, Line 434: // Create a slow scan scenarios. > Yes, this case has done in line 424. Thanks for your advice. Same reason as above. Thanks for the clarification! http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69 PS4, Line 69: and or http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@69 PS4, Line 69: in on http://gerrit.cloudera.org:8080/#/c/19480/4/src/kudu/tserver/scanners.cc@71 PS4, Line 71: expectation Still doesn't make sense. Same comment for similar sentence in COMMIT_MSG. Do you want to say this - "the normal Kudu service unexpectedly" ? -- To view, visit http://gerrit.cloudera.org:8080/19480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96f80561a4c889cbdd1c6dc992184981be86fb6 Gerrit-Change-Number: 19480 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Feb 2023 14:01:11 +0000 Gerrit-HasComments: Yes
