Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19500 )
Change subject: [subprocess] better handling of oversized messages ...................................................................... Patch Set 1: Code-Review+2 (3 comments) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@7 PS1, Line 7: better handling of oversized messages > Never mind, its https://jira.cloudera.com/browse/ENGESC-17533 This is a Cloudera JIRA though. Maybe we could open an Apache JIRA for it and tag it in the commit message? http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_protocol.h File src/kudu/subprocess/subprocess_protocol.h: http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_protocol.h@86 PS1, Line 86: static constexpr uint32_t kMaxMessageBytes = 1024 * 1024; is this still needed? http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_server-test.cc File src/kudu/subprocess/subprocess_server-test.cc: http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_server-test.cc@363 PS1, Line 363: const auto s = server_->Execute(&req, &res); nit: newline -- To view, visit http://gerrit.cloudera.org:8080/19500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05b09e757f304b22e37438c2445ecc161ef412c9 Gerrit-Change-Number: 19500 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Feb 2023 17:23:25 +0000 Gerrit-HasComments: Yes
