Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19500 )
Change subject: KUDU-3450 handling of oversized messages in subprocess server ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@7 PS1, Line 7: better handling of oversized messages > This is a Cloudera JIRA though. Maybe we could open an Apache JIRA for it a Good point. The upstream JIRA is https://issues.apache.org/jira/browse/KUDU-3450 http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@21 PS1, Line 21: server not just bails > nit: server does not just bail Done http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@22 PS1, Line 22: but > nit: rather Done http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@23 PS1, Line 23: discard of the message > nit: discard the message Done http://gerrit.cloudera.org:8080/#/c/19500/1//COMMIT_MSG@26 PS1, Line 26: reflect on > nit: reflect Changed to 'report on' which seems to be the wording of the very first version of this sentence. http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_protocol.h File src/kudu/subprocess/subprocess_protocol.h: http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_protocol.h@86 PS1, Line 86: static constexpr uint32_t kMaxMessageBytes = 1024 * 1024; > is this still needed? indeed, it's no longer needed http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_server-test.cc File src/kudu/subprocess/subprocess_server-test.cc: http://gerrit.cloudera.org:8080/#/c/19500/1/src/kudu/subprocess/subprocess_server-test.cc@363 PS1, Line 363: const auto s = server_->Execute(&req, &res); > nit: newline Done -- To view, visit http://gerrit.cloudera.org:8080/19500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05b09e757f304b22e37438c2445ecc161ef412c9 Gerrit-Change-Number: 19500 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Feb 2023 20:51:30 +0000 Gerrit-HasComments: Yes
