Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19500 )
Change subject: KUDU-3450 handling of oversized messages in subprocess server ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19500/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19500/2//COMMIT_MSG@21 PS2, Line 21: its subprocess. Now, server does not just bail upon a larger than > nit: missing "the" Done http://gerrit.cloudera.org:8080/#/c/19500/2//COMMIT_MSG@37 PS2, Line 37: A follow-up patch should take care of the corresponding client-side > What client-side components are you referring to? I thought only the Master Right, but there is a Java wrapper that reads messages from the other side, i.e. the code that uses MessageIO.readBytes() https://github.com/apache/kudu/blob/9684200713b5e1bf258437527127bd98acfa1e42/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageIO.java#L69-L73 Even if the maximum size is configurable at that side, it's still necessary to update the code to read out an oversized message, if any is sent by from the master side. More details on this is in the description of https://issues.apache.org/jira/browse/KUDU-3450 -- To view, visit http://gerrit.cloudera.org:8080/19500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05b09e757f304b22e37438c2445ecc161ef412c9 Gerrit-Change-Number: 19500 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Feb 2023 22:00:25 +0000 Gerrit-HasComments: Yes
