Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc@9856 PS2, Line 9856: FLAGS_master_support_auto_incrementing_column = true; If set the default value to true, these common tests are not needed to set this flag to true explicitly. http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121 PS2, Line 121: DEFINE_bool(master_support_auto_incrementing_column, false, I'm curious why the default value is false? http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@124 PS2, Line 124: This flag is only for test, right? So we can mark it as 'hidden', maybe 'runtime' is needed too? -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 21 Feb 2023 14:55:58 +0000 Gerrit-HasComments: Yes
