Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/client/client-test.cc@9856 PS2, Line 9856: FLAGS_master_support_auto_incrementing_column = true; > If set the default value to true, these common tests are not needed to set Thanks for jumping in Yingchun! The deal is that for the auto-incrementing column feature, we still need: https://gerrit.cloudera.org/#/c/19445/ . However Abhishek is on vacation for a while. So I figured, I will add the flag to basically disable the auto-incrementing column functionality for now. (not to cause any unwanted issues by default) I will try to look into the above mentioned patch. But I still need to gather context. Once this patch gets merged, I will comment on the release docs, to remove the auto-incrementing column from the release highlights, as it is not fully done/tested yet. -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 21 Feb 2023 15:03:33 +0000 Gerrit-HasComments: Yes
