Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19523 )
Change subject: KUDU-1945 Auto-incrementing column feature flag ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19523/2//COMMIT_MSG@9 PS2, Line 9: This patch adds the flag "--master_support_auto_incrementing_column" to : guard the auto-incrementing column feature According to your explain at another thread. I think the commit messages can be improved by that words. The patch' purpose is that it's a new feature, and may be unsteady or has bugs to fix, so we need guard it, and turn off it right? http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/19523/2/src/kudu/master/master_service.cc@121 PS2, Line 121: master_support_auto_incrementing_column 'master_support_auto_incrementing_column' is added at kudu-master, so 'support_auto_incrementing_column' is ok? In fact, the 'auto-incrementing column' function it's a new feature, and we can view it as unsteady to guard it, right? so we can consider to mark the flag 'master_support_auto_incrementing_column' unsafe and experimental ? -- To view, visit http://gerrit.cloudera.org:8080/19523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd Gerrit-Change-Number: 19523 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 02:50:15 +0000 Gerrit-HasComments: Yes
