Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19522 )
Change subject: [test] Improve the LBM startup benchmark ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM. http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@104 PS1, Line 104: DEFINE_double The type is changed from int32 to double, is there some reason? The validator about double below ' { return 0 <= v && v <= 100; }' , seems a little uneasy. http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@1118 PS1, Line 1118: for (; j < block_ids.size(); j++) { : deletion_transaction->AddDeletedBlock(block_ids[j]); : if (--to_delete_count_per_batch <= 0) { : break; : } : } to_delete_count <= block_ids.size(); (L1106) startup_benchmark_data_dir_count_for_testing should be >=1 (semantics requirement) so to_delete_count_per_batch <= block_ids.size(). It seems ok below: for (; j < to_delete_count_per_batch; j++) { deletion_transaction->AddDeletedBlock(block_ids[j]); } -- To view, visit http://gerrit.cloudera.org:8080/19522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I148c6eebf29a18d680f5372a8f2c4b1f31882371 Gerrit-Change-Number: 19522 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 23 Feb 2023 07:35:38 +0000 Gerrit-HasComments: Yes
