Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19522 )
Change subject: [test] Improve the LBM startup benchmark ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@104 PS1, Line 104: DEFINE_double > The type is changed from int32 to double, is there some reason? Yes, we can test cases of percentage with more accurate values, such as 0.1, 0.01 and etc., to simulate the low live block ratio in real world. http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@1118 PS1, Line 1118: for (; j < block_ids.size(); j++) { : deletion_transaction->AddDeletedBlock(block_ids[j]); : if (--to_delete_count_per_batch <= 0) { : break; : } : } > to_delete_count <= block_ids.size(); (L1106) I want to delete FLAGS_startup_benchmark_deleted_block_percentage percentage of block ids, but in your way, it seems only FLAGS_startup_benchmark_deleted_block_percentage/FLAGS_startup_benchmark_batch_count_for_testing percentage of block ids can be deleted, right? It can't jump in the for loop after j >= to_delete_count_per_batch. -- To view, visit http://gerrit.cloudera.org:8080/19522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I148c6eebf29a18d680f5372a8f2c4b1f31882371 Gerrit-Change-Number: 19522 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 23 Feb 2023 15:46:42 +0000 Gerrit-HasComments: Yes
