Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19522 )
Change subject: [test] Improve the LBM startup benchmark ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@104 PS1, Line 104: DEFINE_double > Yes, we can test cases of percentage with more accurate values, such as 0.1 Yes, I see. And 'startup_benchmark_deleted_block_percentage' flag is defined in this test file, only the cpp file use it, and it is not use other value except the default value 90.0. If percentage 0.01 / 99.99 is useful, I think you can add them in test cases. http://gerrit.cloudera.org:8080/#/c/19522/1/src/kudu/fs/log_block_manager-test.cc@1118 PS1, Line 1118: for (; j < block_ids.size(); j++) { : deletion_transaction->AddDeletedBlock(block_ids[j]); : if (--to_delete_count_per_batch <= 0) { : break; : } : } > I want to delete FLAGS_startup_benchmark_deleted_block_percentage percentag Sorry. Yes, you are right. -- To view, visit http://gerrit.cloudera.org:8080/19522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I148c6eebf29a18d680f5372a8f2c4b1f31882371 Gerrit-Change-Number: 19522 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 02:55:14 +0000 Gerrit-HasComments: Yes
