Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19473 )
Change subject: [clock] add sanity check to detect wall clock jumps ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19473/2//COMMIT_MSG@10 PS2, Line 10: the ntp_adjtime() call jumped 40+ years ahead when running kudu-tserver > Sorry, reply the message too late. It's not a problem. Feel free to post an update whenever you have a chance to capture more details on the case observed in your cluster. Thanks! http://gerrit.cloudera.org:8080/#/c/19473/3/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/19473/3/src/kudu/clock/hybrid_clock.cc@293 PS3, Line 293: uint64_t now_latest = GetPhysicalValueMicros(now) + error; > warning: The right operand of '+' is a garbage value [clang-analyzer-core.U Done http://gerrit.cloudera.org:8080/#/c/19473/3/src/kudu/clock/hybrid_clock.cc@780 PS3, Line 780: } > warning: Undefined or garbage value returned to caller [clang-analyzer-core Done -- To view, visit http://gerrit.cloudera.org:8080/19473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I630783653717d975a9b2ad668e8bd47b7796d275 Gerrit-Change-Number: 19473 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Mar 2023 18:51:19 +0000 Gerrit-HasComments: Yes
