Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/19594/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19594/2//COMMIT_MSG@7 PS2, Line 7: Make validate table creating task not affected I think you can make a summary about jira issue: KUDU-3452 and then introduce this problem you solved in this message. http://gerrit.cloudera.org:8080/#/c/19594/2//COMMIT_MSG@9 PS2, Line 9: Create a three-replicas table when one of three tablet servers : will timeout. Some words need be added and adjusted? Create a three-replicas table will be timeout when one of three tablet servers ...( what? ) http://gerrit.cloudera.org:8080/#/c/19594/2//COMMIT_MSG@10 PS2, Line 10: will timeout. After that, create a two-replicas table also will : timeout nit: will be timeout http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc@1913 PS2, Line 1913: const nit: indent http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc@1916 PS2, Line 1916: 1000 nit: define a variable, eg: kTimeout. because below can use it. http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc@1934 PS2, Line 1934: 2000 nit: 2 * kTimeout http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc@1944 PS2, Line 1944: ASSERT_STR_CONTAINS(s.ToString(), "Timed out waiting for Table Creation"); It seems better that add a checker for the table's status by using 'IsCreateTableDone'. http://gerrit.cloudera.org:8080/#/c/19594/2/src/kudu/tools/kudu-admin-test.cc@1945 PS2, Line 1945: } If tablet_server(0) recovered from failure. What's state of the table kNotEnoughTServersTableId would be? -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 29 Mar 2023 06:40:58 +0000 Gerrit-HasComments: Yes
