Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5934 PS4, Line 5934: // to PREPARING, or its state will become CREATING later. > Why not just remove the tablet from needs_create_rpc to reduce an extra var Done http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5938 PS4, Line 5938: << ", > What the meaning of 'old logic'? The 'old logic' is only reasonable in this OK. I will remove it. http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5940 PS4, Line 5940: { > I not sure if I can get the point, could you please explain about it? In the origin logic, if the state of a tablet is CREATING(persisted by lock_out.Commit()), it means it has finished selecting replicas and prepares to send creating replica PRCs to the tablet servers. If the tablet does not finish selecting replicas, it should recover its state to PREPARING. Or it will wait timeout(defined by --tablet_creation_timeout_ms) and create a new tablet to replace the old one. Please see the function: HandleAssignCreatingTablet(). http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5941 PS4, Line 5941: it++; > Print the returned Status to clearify why select replicas failed. Done -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 02 Apr 2023 14:10:41 +0000 Gerrit-HasComments: Yes
