Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5934 PS4, Line 5934: finish_select_replicas_tablets.push_back(tablet); Why not just remove the tablet from needs_create_rpc to reduce an extra variable? http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5938 PS4, Line 5938: old logic What the meaning of 'old logic'? The 'old logic' is only reasonable in this merge request, it's meaningless if it has been merged. http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5940 PS4, Line 5940: SysTabletsEntryPB::PREPARING I not sure if I can get the point, could you please explain about it? http://gerrit.cloudera.org:8080/#/c/19594/4/src/kudu/master/catalog_manager.cc@5941 PS4, Line 5941: LOG(ERROR) << "Error selecting replicas for tablet " << tablet->id(); Print the returned Status to clearify why select replicas failed. -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 15:39:57 +0000 Gerrit-HasComments: Yes
