Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK ...................................................................... Patch Set 1: (23 comments) http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc File examples/cpp/non_unique_primary_key.cc: http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@80 PS1, Line 80: "non_unique_key" Could we get column name from input schema? http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@98 PS1, Line 98: indent in two spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@109 PS1, Line 109: if (s.ok()) { : return s; : } remove these three lines http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@118 PS1, Line 118: for(int i = 0; i < predicates.size(); i++){ add space after 'for', add a space before { http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@140 PS1, Line 140: for(int i = 0; i < predicates.size(); i++){ add space after 'for', add a space before { http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@158 PS1, Line 158: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@165 PS1, Line 165: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@172 PS1, Line 172: if (s.ok()) { : return s; : } remove http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@184 PS1, Line 184: for(int i = 0; i < predicates.size(); i++){ add space after 'for', add a space before { http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@201 PS1, Line 201: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@208 PS1, Line 208: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@214 PS1, Line 214: if (s.ok()) { : return s; : } remove http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@257 PS1, Line 257: EQUALS why up case? http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@259 PS1, Line 259: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@275 PS1, Line 275: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@278 PS1, Line 278: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@283 PS1, Line 283: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@299 PS1, Line 299: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@319 PS1, Line 319: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@331 PS1, Line 331: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@334 PS1, Line 334: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@339 PS1, Line 339: nit: indent in 4 spaces http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@371 PS1, Line 371: nit: indent in 4 spaces -- To view, visit http://gerrit.cloudera.org:8080/19690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec Gerrit-Change-Number: 19690 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 03:11:19 +0000 Gerrit-HasComments: Yes
