Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc File examples/cpp/non_unique_primary_key.cc: http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@102 PS1, Line 102: incrementin nit: incrementing http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@128 PS1, Line 128: default Remind me if I am wrong but we currently have the default implementation only where the client never hides the auto incrementing column when returning the results of a scan? http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@182 PS1, Line 182: delte nit here and above: delete -- To view, visit http://gerrit.cloudera.org:8080/19690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec Gerrit-Change-Number: 19690 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 03:19:05 +0000 Gerrit-HasComments: Yes
