KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets witout live row count stats ...................................................................... Patch Set 15: (9 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc File src/kudu/tablet/diskrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@778 PS14, Line 778: // The rowset's live row count should be equal when there are no live row count : // stats availab > nit: The rowset's live row count should be equal when there are no live row Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@790 PS14, Line 790: f no DMS exists. > nit: if no DMS exists. Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@790 PS14, Line 790: live row count > nit: live row count Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@806 PS14, Line 806: b > nit: be Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@806 PS14, Line 806: f if no : // DMS exists. > nit: if no DMS exists. Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@818 PS14, Line 818: a D > nit: a DMS Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@824 PS14, Line 824: DMS > nit: DMS Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@828 PS14, Line 828: a DMS exists. > nit: if a DMS exists. Done http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset.h@388 PS14, Line 388: old version > nit: Specify the real version, “versions earlier than 1.10” ? update the co Done -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 02:15:08 +0000 Gerrit-HasComments: Yes
