Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets without live row count stats ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19670/18/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/19670/18/src/kudu/tablet/diskrowset.cc@760 PS18, Line 760: *count = rows_count - deleted_count; I am worried about this deletes and inserts are not one-to-one correspondence. It maybe exist some dangerous scenarios just using counter, because this *count == 1, the rs will be gced. So I advice adding 1 ut for this scenarios: write some insert ops(represent DMS) and then write deletes() and some upsert/inserts again(represent REDO files). This case, rs can not be gced, but it maybe satisfy this gc condition. -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 19 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:52:20 +0000 Gerrit-HasComments: Yes
