Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 )
Change subject: KUDU-3371 [fs] make LogBlockContainer a base class ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc@629 PS3, Line 629: virtual void AfterBlocksDeleted() {} > How about 'PostWorkAfterBlocksDeleted()'? name PostWorkAfterBlocksDeleted ok. I have no strong reason to advice this, because the class is not an interface define. Some work should do AfterBlocksDeleted, this behavior sounds like a common work. This patch's correctness I think it's no problem. I just worry some mistake in the future. http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc@743 PS3, Line 743: LogBlockContainerNativeMeta > It is corresponding to LogBlockManagerNativeMeta in https://github.com/apac This advantage is satisfied semantics. The codes that don't satisfy semantics can cause mistake. LogBlockContainerNativeMeta seems LogBlockContainer's meta part. But in fact, it's a kind of LogBlockContainer. So I say you'd better rename the name like 'NativeLogBlockContainer' The discuss about 'Furthermore, IMO, ...', I say some about software engineer's personal opinion. That's an opinion differ from each other. -- To view, visit http://gerrit.cloudera.org:8080/19610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb199de95973aaeba76947ad095907272d84ca67 Gerrit-Change-Number: 19610 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 06:47:27 +0000 Gerrit-HasComments: Yes
