Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 )
Change subject: KUDU-3371 [fs] make LogBlockContainer a base class ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc@629 PS3, Line 629: virtual void AfterBlocksDeleted() {} > name PostWorkAfterBlocksDeleted ok. Thanks, Yuqi! I renamed it to PostWorkOfBlocksDeleted, because "post" has the meaning of "after". http://gerrit.cloudera.org:8080/#/c/19610/3/src/kudu/fs/log_block_manager.cc@743 PS3, Line 743: LogBlockContainerNativeMeta > This advantage is satisfied semantics. The codes that don't satisfy semanti The existed log block manager which manage containers with native meta is named as LogBlockManagerNativeMeta, so the LogBlockContainerNativeMeta is to keep the consistency, or that will cause misunderstanding. We can rename both of them in future if you insist that :) -- To view, visit http://gerrit.cloudera.org:8080/19610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb199de95973aaeba76947ad095907272d84ca67 Gerrit-Change-Number: 19610 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 07 May 2023 16:36:18 +0000 Gerrit-HasComments: Yes
