Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 )
Change subject: KUDU-3371 [fs] make LogBlockContainer a base class ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.h@70 PS4, Line 70: ContainerBlocksByName; > nit: there is no 'liveliness' context in here, isn't it? Maybe, name this Done http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.h@352 PS4, Line 352: // The following addi > Making this virtual along with DoRepair() seems a bit of an overkill. Woul Done http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.h@366 PS4, Line 366: > It's not quite clear how this is different from the Repair() method. It wo Done http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.h@538 PS4, Line 538: > Would be great to document the expectations on 'container' when this method Done http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19610/4/src/kudu/fs/log_block_manager.cc@2879 PS4, Line 2879: // TODO(unknown): what if this fails? Should we restore the in-memory block? : vector<BlockId> deleted_block_ids; : Status s = container->RemoveBlockIdsFromMetadata(clbs, &deleted_block_ids); : : // We don't bother fsyncing the metadata append for deletes in order to avoid : // the disk overhead. Even if we did fsync it, we'd still need to account for : // garbage at startup time (in the event that we crashed just before the : // fsync). : / > readability nit: consider rewriting this as Done -- To view, visit http://gerrit.cloudera.org:8080/19610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb199de95973aaeba76947ad095907272d84ca67 Gerrit-Change-Number: 19610 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:25:32 +0000 Gerrit-HasComments: Yes
