Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets without live row count stats ...................................................................... Patch Set 19: Code-Review+1 (2 comments) > Patch Set 19: > > (1 comment) currently LGTM, and I have a question at src/kudu/tablet/tablet_history_gc-test.cc:754. http://gerrit.cloudera.org:8080/#/c/19670/18/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/19670/18/src/kudu/tablet/diskrowset.cc@760 PS18, Line 760: *count = rows_count - deleted_count; > Yeah, this is a good question. ok. I have run some variants cases from this. This is no problems. http://gerrit.cloudera.org:8080/#/c/19670/19/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: http://gerrit.cloudera.org:8080/#/c/19670/19/src/kudu/tablet/tablet_history_gc-test.cc@750 PS19, Line 750: // We can't get the exact count of live row without live_row_count feature. : // If we disable the live_row_count, the imprecise counting will not trigger the GC. : // However, this is expected and will not cause any errors, so we can directly ignore this : // unit testcase at this time. : NO_FATALS(TryRunningDeletedRowsetGCWithoutEffect()); I have a confuse question. This branch seems to imply that the patch has not done completely because of 'delta_tracker_->CountDeletedRowsInRedos()/ delta_store_stats ' is not exactly as it is? Although, this test case does nothing, but how much probability would it work? -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 19 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 29 Apr 2023 15:45:56 +0000 Gerrit-HasComments: Yes
