KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets without live row count stats ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19670/19/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: http://gerrit.cloudera.org:8080/#/c/19670/19/src/kudu/tablet/tablet_history_gc-test.cc@750 PS19, Line 750: // We can't get the exact count of live row without live_row_count feature. : // If we disable the live_row_count, the imprecise counting will not trigger the GC. : // However, this is expected and will not cause any errors, so we can directly ignore this : // unit testcase at this time. : NO_FATALS(TryRunningDeletedRowsetGCWithoutEffect()); > I have a confuse question. Yes, the triggering of this branch is accompanied by a certain probability. The target scenario for this patch is a long time without read/write operations, full of delete operations, and the problem of data that cannot be released without live row counts. We only need to ensure that our GC scheduling strategy can take effect in this scenario and does not affect other normal scenarios to achieve our goal. -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 19 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 30 Apr 2023 05:27:22 +0000 Gerrit-HasComments: Yes
