Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19833 )
Change subject: [build-support] fix build on CentOS/RHEL ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh@89 PS1, Line 89: if lsb_release -irs > /dev/null 2>&1; then : LSB_INFO="$(lsb_release -irs 2>/dev/null)" : if [[ "$LSB_INFO" =~ (CentOS|RedHatEnterpriseServer|OracleServer)[[:space:]]+(6|7)(\.[[:digit:]]+)* ]]; then : custom_run_at_rhel $@ : elif [[ "$LSB_INFO" =~ (SUSE)[[:space:]]+1[25](\.[[:digit:]]+)* ]]; then : custom_run_at_sles $@ : else : # Run as-is : $@ : fi Does it makes sense to get rid of lsb_release altogether if it is not supported in RHEL/CentOS9? If /etc/os_release alone is not dependable in older versions, can we comment that in line 86? -- To view, visit http://gerrit.cloudera.org:8080/19833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8069c09bc5be174b40b7b9cff856af4ad54652a Gerrit-Change-Number: 19833 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 03 May 2023 02:55:05 +0000 Gerrit-HasComments: Yes
