Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19833 )

Change subject: [build-support] fix build on CentOS/RHEL
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:

http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh@89
PS1, Line 89: #
            :   # From the other side, legacy releases such as CentOS/RHEL 6 
don't have
            :   # /etc/os-release as a part of its 'centos-release' package. 
So, this
            :   # helper script relies on a hybrid approach.
            :   #
            :   # TODO(aserbin): deprecate the usage of lsb_release and switch 
to using
            :   #                /etc/os-release once support for legacy Linux 
OS releases
            :   #                isn't needed
            :   OS_REL_FILE="/etc/os-release"
            :
> Yes -- at some point maybe, but not exactly now.
Thank you for that.



-- 
To view, visit http://gerrit.cloudera.org:8080/19833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8069c09bc5be174b40b7b9cff856af4ad54652a
Gerrit-Change-Number: 19833
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 May 2023 06:21:45 +0000
Gerrit-HasComments: Yes

Reply via email to