Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19833 )
Change subject: [build-support] fix build on CentOS/RHEL ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/19833/1/build-support/enable_devtoolset.sh@89 PS1, Line 89: # : # From the other side, legacy releases such as CentOS/RHEL 6 don't have : # /etc/os-release as a part of its 'centos-release' package. So, this : # helper script relies on a hybrid approach. : # : # TODO(aserbin): deprecate the usage of lsb_release and switch to using : # /etc/os-release once support for legacy Linux OS releases : # isn't needed : OS_REL_FILE="/etc/os-release" : > Does it makes sense to get rid of lsb_release altogether if it is not suppo Yes -- at some point maybe, but not exactly now. If switching away from lsb_release to /etc/os-release, I guess we want to deprecate the former at legacy releases where Kudu is already supported and where the usage of lsb_release is documented as of current version of https://kudu.apache.org/docs/installation.html And then switch to using /etc/os-release completely. Also, CentOS/RHEL 6 doesn't have /etc/os-release (the centos-release package provides only /etc/centos-release file but not /etc/os-release). I added a commented on that. -- To view, visit http://gerrit.cloudera.org:8080/19833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8069c09bc5be174b40b7b9cff856af4ad54652a Gerrit-Change-Number: 19833 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 03 May 2023 04:22:05 +0000 Gerrit-HasComments: Yes
